Pac4jSessionStore: Update Salt Size#15758
Merged
abhishekagarwal87 merged 2 commits intoapache:masterfrom Jan 25, 2024
Merged
Conversation
Updating to latest master
abhishekagarwal87
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of becoming FIPS compliance, we are seeing this error:
salt must be at least 128 bitswhen we run the Druid code against FIPS Compliant cryptographic security providers.This PR fixes the salt size used in Pac4jSessionStore.java
Description
Salting refers to adding random data to a hash function to obtain a unique output which refers to the hash. Even when the same input is used, it is possible to obtain different and unique hashes. These hashes aim to strengthen security, protect against dictionary attacks, brute-force attacks, and several others. Very short salts are easier to attack and breach, thereby compromising your password.
Fixed the bug ...
Salt Size while invoking CryptoService must be atleast 128 bits.
Renamed the class
None
Added a forbidden-apis entry ...
None
Release note
This PR has: