Rename the recordsProcessed field introduced in #15930#15958
Closed
ac9817 wants to merge 1 commit intoapache:masterfrom
Closed
Rename the recordsProcessed field introduced in #15930#15958ac9817 wants to merge 1 commit intoapache:masterfrom
ac9817 wants to merge 1 commit intoapache:masterfrom
Conversation
10 tasks
Contributor
|
I noticed the live reports for the supervisor that report offsets and lag do not mention @kfaraz I do not have a strong opinion about this re-name. Up to you which key name you think is better. |
Contributor
|
Thanks for the clarification, @suneet-s . Looking at the sample report, I realize that the word @adithyachakilam , you may close this pull request for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the rename suggested here: #15930 (comment)
The map structure for
recordsProcessedis difficult for someone to understand without knowing the knowledge of partitions. Hence renamed it accordingly.Key changed/added classes in this PR
IngestionStatsAndErrorsTaskReportDataThis PR has: