fix REGEXP_LIKE, CONTAINS_STRING, ICONTAINS_STRING for correct 3vl behavior#15963
Conversation
…tead of false for null inputs in sql compatible mode
|
let's put it behind one of these feature flags, please :) My experience is that long-time users often adjust to this weird behavior and then complain about their workflows breaking. |
The problem is that neither of these feature flags seem very appropriate. I'm pretty strongly opposed to adding yet another feature flag for a bug fix, it isn't really sustainable. This fix already only has any effect if |
abhishekagarwal87
left a comment
There was a problem hiding this comment.
LGTM. The SQL compatibility feature flag is good enough.
Description
Fixes
regexp_like,contains_string, andicontains_stringto returnnullinstead offalsein SQL compatible null handling mode to have correct three-value logic behavior. I did not put this behavior behind a flag, though if we are worried about the bug fix changing behavior I suppose we could associate it withNullHandling.useThreeValueLogic(), though kind of weird since that is currently tied to use for native filters, orExpressionProcessing.useStrictBooleans()which traditionally controls the other expression related 3vl stuff.Release note
REGEXP_LIKE,CONTAINS_STRING, andICONTAINS_STRINGcorrectly return null for null value inputs in SQL compatible null handling mode (the default configuration).This PR has: