Segments created in the same batch have the same created_date entry & rename metric#15977
Merged
abhishekrb19 merged 3 commits intoapache:masterfrom Feb 27, 2024
Merged
Conversation
In the absence of a group_id column, this metadata would allow us to easily reason about and troubleshoot ingestion-related issues.
abhishekrb19
force-pushed
the
created_time_insert
branch
from
51b4cf2 to
ebc2a0f
Compare
Address review comment from apache#15941 (comment)
abhishekrb19
force-pushed
the
created_time_insert
branch
from
5ec6d67 to
aa1bee5
Compare
abhishekrb19
changed the title
created_date entrycreated_date entry & rename metric
kfaraz
approved these changes
Feb 27, 2024
|
|
||
| // Each unused segment interval returned above has a 1:1 correspondence with an unused segment. So we can assume | ||
| // these are candidate segments eligible for deletion by the kill task. After the umbrella interval is computed | ||
| // these are eligible segments for deletion by the kill task. After the umbrella interval is computed |
Contributor
There was a problem hiding this comment.
Suggested change
| // these are eligible segments for deletion by the kill task. After the umbrella interval is computed | |
| // these are segments eligible for deletion by the kill task. After the umbrella interval is computed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
ebc2a0f: Materialize
created_dateoutside the for loop, so all the segments created in a batch have the samecreated_dateentry. In the absence of agroup_idcolumn, this metadata would allow us to easily reason about and troubleshoot ingestion-related issues.aa1bee5: Address review comment from Refactor and add tests and metric to KillUnusedSegments duty (auto-kill) #15941 (comment) in. The metric name and description along with the code references are updated.
This PR has: