Add indexer level task metrics to provide more visibility in the task distribution#15991
Merged
kfaraz merged 9 commits intoapache:masterfrom Mar 21, 2024
Merged
Conversation
kfaraz
reviewed
Feb 28, 2024
| @Before | ||
| public void setUp() | ||
| { | ||
| task = createMock(Task.class); |
Contributor
There was a problem hiding this comment.
Use NoopTask instead of creating a mock.
| taskDetails = createMock(WorkerTaskManager.TaskDetails.class); | ||
| EasyMock.expect(taskDetails.getDataSource()).andReturn("dummy_DS2"); | ||
| EasyMock.replay(taskDetails); | ||
| taskAnnouncement = createMock(TaskAnnouncement.class); |
Contributor
There was a problem hiding this comment.
Try to use concrete instances of TaskAnnouncement and TaskDetails (if needed) instead of mocks.
| EasyMock.replay(taskAnnouncement); | ||
| taskRunner = createMock(TaskRunner.class); | ||
| taskConfig = createMock(TaskConfig.class); | ||
| overlordClient = createMock(OverlordClient.class); |
Contributor
There was a problem hiding this comment.
Use NoopOverlordClient instead.
kfaraz
reviewed
Mar 7, 2024
Contributor
Author
kfaraz
approved these changes
Mar 7, 2024
| public interface IndexerTaskCountStatsProvider | ||
| { | ||
| /** | ||
| * The number of running tasks on an indexer |
Contributor
There was a problem hiding this comment.
Minor suggestion for the javadocs but this can be addressed later.
Suggested change
| * The number of running tasks on an indexer | |
| * Map from datasource name to the number of running tasks on the Indexer. |
…indexerTaskCountStatsProvides
Contributor
|
@rbankar7 , the checkstyle and |
Contributor
|
@rbankar7 , there are more checkstyle failures. To ensure that you catch all of them, please run the following on your local machine before you commit: |
Contributor
Author
|
@kfaraz I fixed the issues and verified that there are no checkstyle errors |
Contributor
|
@rbankar7 , I ran the workflow. The test Error: Errors:
Error: org.apache.druid.server.metrics.WorkerTaskCountStatsMonitorTest.testMonitorNotMiddleManager
Error: Run 1: WorkerTaskCountStatsMonitorTest.testMonitorNotMiddleManager:288 » Configuration Guice configuration errors:
1) No implementation for org.apache.druid.server.metrics.IndexerTaskCountStatsProvider was bound.
while locating org.apache.druid.server.metrics.IndexerTaskCountStatsProviderThe code coverage also seems insufficient for |
Contributor
Author
@kfaraz will fix it |
…nitorIndexer) and add tests for getting worker stats
Contributor
Author
|
@kfaraz looks like build is passing now |
Contributor
|
Thanks a lot for the fix, @rbankar7 ! |
rbankar7
added a commit
to confluentinc/druid
that referenced
this pull request
Mar 22, 2024
… distribution (apache#15991) Changes: Add the following indexer level task metrics: - `worker/task/running/count` - `worker/task/assigned/count` - `worker/task/completed/count` These metrics will provide more visibility into the tasks distribution across indexers (We often see a task skew issue across indexers and with this issue it would be easier to catch the imbalance)
10 tasks
rbankar7
added a commit
to confluentinc/druid
that referenced
this pull request
Mar 22, 2024
… distribution (apache#15991) Changes: Add the following indexer level task metrics: - `worker/task/running/count` - `worker/task/assigned/count` - `worker/task/completed/count` These metrics will provide more visibility into the tasks distribution across indexers (We often see a task skew issue across indexers and with this issue it would be easier to catch the imbalance)
10 tasks
rbankar7
added a commit
to confluentinc/druid
that referenced
this pull request
Mar 26, 2024
…re visibility (#191) * Add indexer level task metrics to provide more visibility in the task distribution (apache#15991) Changes: Add the following indexer level task metrics: - `worker/task/running/count` - `worker/task/assigned/count` - `worker/task/completed/count` These metrics will provide more visibility into the tasks distribution across indexers (We often see a task skew issue across indexers and with this issue it would be easier to catch the imbalance)
rbankar7
added a commit
to confluentinc/druid
that referenced
this pull request
Apr 2, 2024
… distribution (apache#15991) (#192) Changes: Add the following indexer level task metrics: - `worker/task/running/count` - `worker/task/assigned/count` - `worker/task/completed/count` These metrics will provide more visibility into the tasks distribution across indexers (We often see a task skew issue across indexers and with this issue it would be easier to catch the imbalance)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds indexer level task metrics
Description
This PR adds indexer level task metrics-
These metrics will provide more visibility into the tasks distribution across indexers (We often see a task skew issue across indexers and with this issue it would be easier to catch the imbalance)
This PR has: