Upgrade pending segments transactionally#15992
Closed
AmatyaAvadhanula wants to merge 3 commits intoapache:masterfrom
Closed
Upgrade pending segments transactionally#15992AmatyaAvadhanula wants to merge 3 commits intoapache:masterfrom
AmatyaAvadhanula wants to merge 3 commits intoapache:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| activeRealtimeSequencePrefixes = ImmutableSet.of(); | ||
| } else { | ||
| activeRealtimeSequencePrefixes | ||
| = supervisorManager.getActiveRealtimeSequencePrefixes(activeSupervisorIdWithAppendLock.get()); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
Contributor
Author
|
This is being done as part of #16144 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The segment transactional replace action facilitates concurrent replace with streaming append by
Presently both the steps happen outside the transaction in which the replacing segments are committed.
This PR aims to fix potential conflicts by ensuring that the pending segment upgrade happens in the same transaction in which the segments are committed.
This PR has: