Skip to content

update common-compress to address CVE-2024-25710 CVE-2024-26308 #16009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xvrl merged 6 commits into from
Feb 29, 2024
Merged

update common-compress to address CVE-2024-25710 CVE-2024-26308 #16009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83c8d68
update common-compress
janjwerner-confluent Feb 29, 2024
99f10e5
update commons-codec, add commons-codec to processing
janjwerner-confluent Feb 29, 2024
55a5813
rename group
janjwerner-confluent Feb 29, 2024
2152f2c
change scope of commons-codec to satisfy the dependency check
janjwerner-confluent Feb 29, 2024
ce39874
added reasoning for commons-codec
janjwerner-confluent Feb 29, 2024
35283ff
Update processing/pom.xml
janjwerner-confluent Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions licenses.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ name: Apache Commons Codec
license_category: binary
module: java-core
license_name: Apache License version 2.0
version: 1.16.0
version: 1.16.1
libraries:
- commons-codec: commons-codec
notices:
Expand Down Expand Up @@ -632,7 +632,7 @@ name: Apache Commons Compress
license_category: binary
module: java-core
license_name: Apache License version 2.0
version: 1.24.0
version: 1.26.0
libraries:
- org.apache.commons: commons-compress
notices:
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
<version>1.16.0</version>
<version>1.16.1</version>
</dependency>
<dependency>
<groupId>commons-io</groupId>
Expand Down Expand Up @@ -572,7 +572,7 @@
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
<version>1.24.0</version>
<version>1.26.0</version>
</dependency>
<dependency>
<groupId>org.tukaani</groupId>
Expand Down
6 changes: 6 additions & 0 deletions processing/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
</dependency>
<!-- commons-codec is an optional dependency of commons-compress starting with 1.26.0 which we require at runtime -->
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
<scope>runtime</scope>
Copy link
Copy Markdown
Member

@xvrl xvrl Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason we need to add this dependency to the processing pom?
It also seems odd we would only be declaring it a runtime dependency.

Copy link
Copy Markdown
Contributor Author

@janjwerner-confluent janjwerner-confluent Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's added to processing as this is where commons-compress is used.
The dependency is listed as optional for commons-compress (https://mvnrepository.com/artifact/org.apache.commons/commons-compress/1.26.0)
and is not needed compile time. The dependency is needed runtime (as illustrated by failing tests in #15932). If we add it in the compile scope we will need to add the suppression of dependency analyze tool.

Copy link
Copy Markdown
Member

@xvrl xvrl Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, can we add a comment to explain the reason for making it runtime?

Let's also update the PR description to mention that 1.26 added this optional dependency and that it is required in our case to make tests pass.

</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-math3</artifactId>
Expand Down