remove aws-sdk from ranger-extension#16011
Merged
xvrl merged 8 commits intoapache:masterfrom Mar 8, 2024
Merged
Conversation
Contributor
|
Is it safe to exclude the dependency? Last I checked, the ranger did rely on AWS Cloudwatch for some things. Do we not use that functionality in Druid? |
xvrl
reviewed
Feb 29, 2024
xvrl
reviewed
Feb 29, 2024
…tisfy dependency analyzer
xvrl
approved these changes
Mar 1, 2024
xvrl
approved these changes
Mar 1, 2024
Member
xvrl
left a comment
There was a problem hiding this comment.
LGTM once static checks / tests pass.
xvrl
reviewed
Mar 1, 2024
Contributor
|
why does the description says "azure-sdk"? |
Contributor
Author
brain freeze I guess, fixed it :) |
abhishekagarwal87
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # size blowup regression introduced in #15443
Description
This PR removes the transitive dependency of ranger-plugins-audit to reduce the size of the compiled artifacts
This PR has: