Add support for AzureDNSZone enabled storage accounts used for deep storage#16016
Merged
zachjsh merged 3 commits intoapache:masterfrom Mar 4, 2024
Merged
Add support for AzureDNSZone enabled storage accounts used for deep storage#16016zachjsh merged 3 commits intoapache:masterfrom
zachjsh merged 3 commits intoapache:masterfrom
Conversation
…torage Added a new config to AzureAccountConfig `storageAccountEndpointSuffix` which allows the user to specify a storage account endpoint suffix where the underlying storage account is enabled for AzureDNSZone. The previous config `endpointSuffix`, did not allow support for such accounts. The previous config has been deprecated in favor of this new config. Also fixed an issue where `managedIdentityClientId` was not being set properly
georgew5656
reviewed
Feb 29, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Properties properties = initializePropertes(); | ||
| AzureAccountConfig config = makeInjectorWithProperties(properties).getInstance(AzureAccountConfig.class); | ||
| Assert.assertEquals(config.getEndpointSuffix(), AzureUtils.DEFAULT_AZURE_ENDPOINT_SUFFIX); | ||
| Assert.assertNull(config.getEndpointSuffix()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
georgew5656
approved these changes
Mar 1, 2024
jon-wei
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new config to AzureAccountConfig
storageAccountEndpointSuffixwhich allows the user to specify a storage account endpoint suffix where the underlying storage account is enabled for AzureDNSZone. The previous config
endpointSuffix, did not allow support for such accounts. The previous config has been deprecated in favor of this new config. Also fixed an issue wheremanagedIdentityClientIdwas not being set properlyThis PR has: