Skip to content

upgrade mysql:mysql-connector-java to 8.2.0#16024

Merged
FrankChen021 merged 3 commits intoapache:masterfrom
AlbericByte:mysql
May 6, 2024
Merged

upgrade mysql:mysql-connector-java to 8.2.0#16024
FrankChen021 merged 3 commits intoapache:masterfrom
AlbericByte:mysql

Conversation

@AlbericByte
Copy link
Copy Markdown
Contributor

@AlbericByte AlbericByte commented Mar 1, 2024

Fixes #13389.

Description

upgrade the mysql:mysql-connector-java to 8.0.28

upgrade the package version

Release note

Upgrade mysql:mysql-connector-java to 8.0.28

Key changed/added classes in this PR
  • MySQLConnector.java
  • MySQLConnectorTest.java
  • pom.xml
This PR has:
  • been self-reviewed.
  • using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@cryptoe
Copy link
Copy Markdown
Contributor

cryptoe commented Mar 4, 2024

Similar work happening in this PR as well: https://github.com/apache/druid/pull/15408/files

@AlbericByte AlbericByte mentioned this pull request Mar 4, 2024
Closed
1 task
@AlbericByte AlbericByte changed the title upgrade mysql:mysql-connector-java to 8.0.28 upgrade mysql:mysql-connector-java to 8.2.0 Apr 15, 2024
FrankChen021
FrankChen021 reviewed Apr 19, 2024
View reviewed changes
Comment thread ...c/test/java/org/apache/druid/query/lookup/namespace/JdbcExtractionNamespaceUrlCheckTest.java

@Test
public void testWhenInvalidUrlFormat()
{
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this removed

Copy link
Copy Markdown
Contributor Author

@AlbericByte AlbericByte Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parser no longer checks if every component is in the expected format it only checks if the URL starts with one of the required schema i.e jdbc:mysql,jdbc:mysql:loadbalancer, etc. So we will not be able to determine if this is a valid/invalid URL just by using the parser.

The way to determine if the URL is valid is by creating a connection with the DB.
😄

Comment thread ...tadata-storage/src/test/java/org/apache/druid/metadata/storage/mysql/MySQLConnectorTest.java
connector.connectorIsTransientException(new SQLException("totally realistic test data", "s0", 1337))
);
// this method does not specially handle normal transient exceptions either, since it is not vendor specific
Assert.assertFalse(
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it changed from assertFalse to assertTrue

Copy link
Copy Markdown
Contributor Author

@AlbericByte AlbericByte Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time first.

  • We changed MYSQL_TRANSIENT_EXCEPTION_CLASS_NAME from "com.mysql.jdbc.exceptions.MySQLTransientException" to "java.sql.SQLTransientException"

  • And in mysql-connector-j-8.2.0.jar, we do not have MySQLTransientException.

Comment thread ...-storage/src/test/java/org/apache/druid/firehose/sql/MySQLFirehoseDatabaseConnectorTest.java
}

@Test
public void testFindPropertyKeysFromInvalidConnectUrl()
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense to remove this duplicate test

Copy link
Copy Markdown
Contributor Author

@AlbericByte AlbericByte Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

FrankChen021
FrankChen021 approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

@FrankChen021 FrankChen021 merged commit 92fb0ff into apache:master May 6, 2024
@AlbericByte AlbericByte deleted the mysql branch May 6, 2024 17:08
@FrankChen021 FrankChen021 mentioned this pull request Aug 2, 2024
Closed
cryptoe pushed a commit that referenced this pull request Sep 3, 2024
@AlbericByte @cryptoe
upgrade mysql:mysql-connector-java to 8.2.0 (#16024)
3fe0b30 
* upgrade mysql:mysql-connector-java to 8.2.0

* fix the check errors

* remove unused comment

(cherry picked from commit 92fb0ff)
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
@cryptoe cryptoe modified the milestones: 31.0.0, 30.0.1 Oct 9, 2024
@kfaraz kfaraz mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrankChen021 FrankChen021 FrankChen021 approved these changes

Assignees

No one assigned

Labels

Area - Dependencies Area - Documentation Area - Lookups

Projects

None yet

Milestone

30.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@AlbericByte @cryptoe @FrankChen021 @kfaraz