Skip to content

Pull up literals in InputAccessor#16033

Merged
soumyava merged 3 commits intoapache:masterfrom
kgyrtkirk:pull-up-literals
Mar 12, 2024
Merged

Pull up literals in InputAccessor#16033
soumyava merged 3 commits intoapache:masterfrom
kgyrtkirk:pull-up-literals

Conversation

@kgyrtkirk
Copy link
Copy Markdown
Member

@kgyrtkirk kgyrtkirk commented Mar 4, 2024

  • pull up literals in InputAccessor
  • remove the need to pass constants of Window operator

Fixes #15353

This PR has:

  • been self-reviewed.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.

@kgyrtkirk kgyrtkirk marked this pull request as ready for review March 4, 2024 12:42
* pull up literals in `InputAccessor`
* remove the need to pass `constants` of `Window`  operator

Fixes apache#15353
Copy link
Copy Markdown
Contributor

@soumyava soumyava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumyava soumyava merged commit 8252d72 into apache:master Mar 12, 2024
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to set literal arguments for sketch functions processing subquery results

3 participants