[Backport] Remove exception on failure response from GCS delete API#16085
Closed
gargvishesh wants to merge 27 commits intoapache:29.0.1from
Closed
[Backport] Remove exception on failure response from GCS delete API#16085gargvishesh wants to merge 27 commits intoapache:29.0.1from
gargvishesh wants to merge 27 commits intoapache:29.0.1from
Conversation
Co-authored-by: Abhishek Radhakrishnan <abhishek.rb19@gmail.com>
* change runtime exception class for code coverage * Add file paths for batch delete failures
Contributor
|
@gargvishesh, can you please do a clean backport of only the merge commit bed5d9c from master instead of the entire branch? |
This reverts commit b325fbb.
This reverts commit 543f27d.
This reverts commit 135448c.
This reverts commit 129c6b4.
This reverts commit a1535d0.
This reverts commit 3ac09ef.
This reverts commit 49a9c3f.
This reverts commit 46642ed.
This reverts commit 327caf8.
This reverts commit c31ab89.
This reverts commit e3606f6.
This reverts commit dd7a1af.
This reverts commit 86e73e5.
* Throw 404 Exception on failure response from GCS delete API * Replace String.format * Apply suggestions from code review Co-authored-by: Abhishek Radhakrishnan <abhishek.rb19@gmail.com> * Remove exception for file not found and fix tests * Add warn log and fix intellij inspection errors * More intellij inspection fixes * * Change to debug log * change runtime exception class for code coverage * Add file paths for batch delete failures * Move failedPaths computation to inside isDebugEnabled flag * Correct handling of StorageException * Address review comments * Remove unused exceptions * Address code coverage and review comments * Minor corrections --------- Co-authored-by: Abhishek Radhakrishnan <abhishek.rb19@gmail.com> (cherry picked from commit bed5d9c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: #16047