Handling array with boolean literals#16093
Merged
abhishekagarwal87 merged 4 commits intoapache:masterfrom Mar 12, 2024
Merged
Conversation
| if (longVal == null) { | ||
| resultAsBooleanList.add(null); | ||
| } else { | ||
| resultAsBooleanList.add(longVal.longValue() > 0); |
Member
There was a problem hiding this comment.
nit: could use Evals.asBoolean here just on the off chance we ever change how we coerce longs into booleans in the native layer, but this is probably safe too
sreemanamala
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handling array with boolean literals like
ARRAY[true, false]Druid appears to be able to convert an array with boolean expressions like this array[added=deleted, added=delta] into a numeric array of 0 and 1:
select array[added=deleted, added=delta] from wikipediaHowever,
select array[true, false] from wikipediadoesn't work.This PR fixes this.
Key changed/added classes in this PR
DruidRexExecutorCalciteArraysQueryTestThis PR has: