Skip to content

Add tests for concurrent replace with streaming append#16115

Closed
AmatyaAvadhanula wants to merge 1 commit intoapache:masterfrom
AmatyaAvadhanula:test_concurrent_replace_streaming_append
Closed

Add tests for concurrent replace with streaming append#16115
AmatyaAvadhanula wants to merge 1 commit intoapache:masterfrom
AmatyaAvadhanula:test_concurrent_replace_streaming_append

Conversation

@AmatyaAvadhanula
Copy link
Copy Markdown
Contributor

@AmatyaAvadhanula AmatyaAvadhanula commented Mar 13, 2024 •
edited
Loading

WIP:
Tests based on Concurrent replace with streaming append specifically

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 13, 2024
View reviewed changes
Comment thread ...-service/src/test/java/org/apache/druid/indexing/common/task/concurrent/ActionsTestTask.java
);
}

public Map<SegmentId, SegmentId> getAnnouncedSegmentsToParentSegments()

Check notice

Code scanning / CodeQL

Exposing internal representation

getAnnouncedSegmentsToParentSegments exposes the internal representation stored in field announcedSegmentsToParentSegments. The value may be modified [after this call to getAnnouncedSegmentsToParentSegments](1). getAnnouncedSegmentsToParentSegments exposes the internal representation stored in field announcedSegmentsToParentSegments. The value may be modified [after this call to getAnnouncedSegmentsToParentSegments](2).
@kfaraz
Copy link
Copy Markdown
Contributor

kfaraz commented Mar 14, 2024

If the new test class is mostly a copy of the original one and uses all the same methods, then we should just update the original test class to run in a parameterized manner.

1st parameter would run in the current mode, 2nd parameter would run in the streaming mode.

@AmatyaAvadhanula
Copy link
Copy Markdown
Contributor Author

AmatyaAvadhanula commented Mar 18, 2024

Closing in favor of #16144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area - Ingestion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AmatyaAvadhanula @kfaraz @github-advanced-security