Skip to content

Adding more logging for s3 RetryableS3OutputStream #16117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LakshSingla merged 2 commits into from
Mar 14, 2024
Merged

Adding more logging for s3 RetryableS3OutputStream #16117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0da7c56
Better retryable stream s3 logging
cryptoe Mar 13, 2024
d6d8d47
Adding suggestions
cryptoe Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,12 @@ public void close() throws IOException
// Closeables are closed in LIFO order
closer.register(() -> {
// This should be emitted as a metric
LOG.info("Total push time: [%d] ms", pushStopwatch.elapsed(TimeUnit.MILLISECONDS));
LOG.info(
"Pushed total [%d] parts containing [%d] bytes in [%d]ms.",
numChunksPushed,
resultsSize,
pushStopwatch.elapsed(TimeUnit.MILLISECONDS)
);
});

closer.register(() -> org.apache.commons.io.FileUtils.forceDelete(chunkStorePath));
Expand Down