Fix Cannot mark an unqueryable datasource's segments used / unused#16127
Fix Cannot mark an unqueryable datasource's segments used / unused#16127abhishekrb19 merged 4 commits intoapache:masterfrom
Conversation
|
Good catch 👍 It's also probably worth mentioning in the PR description that this bug exists only when users are marking segments as used by interval or by segment ids for a datasource that contains no used segments. In other words, users can still recover a datasource by marking all segments as used, via |
zachjsh
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return 0; | ||
| } | ||
| if (payload == null || !payload.isValid()) { | ||
| log.warn("Invalid request payload: [%s]", payload); |
Check notice
Code scanning / CodeQL
Use of default toString()
| Assert.assertEquals(ImmutableMap.of("numChangedSegments", 0), response.getEntity()); | ||
| EasyMock.verify(segmentsMetadataManager); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is there a similar test for markAsUnused API where there are no used segments or only used segments in the deep storage, and the operation still proceeds now that we have removed the short circuit? If not, I can add a test in this patch #16136
5 participants
Fixes #16125
Description
This fixes an issue in which a datasource that does not have any segments loaded on historicals, cannot have its segments mark used or unused. Such a datasource may arise because all of it's segments were previously marked as unused, or if all of its segments are cold. This bug effectively did not allow a user to recover or hard-delete a datasource in this state unless they used the apis to mark ALL segments used / unused.
The issue was that there was a check that short circuits the work to mark segments used / unused if it thinks that the datasource does not exist; this check was equated to whether the datasource had any segments presently loaded on any historicals. The issue was fixed by removing this short circuit check.
Release note
Fixed bug that dissallowed marking segment by id / specific interval as used or unused if the datasource doest not have any segments loaded on historicals.
Key changed/added classes in this PR
This PR has: