Add versions to markUsed and markUnused APIs#16141
Merged
abhishekrb19 merged 17 commits intoapache:masterfrom Mar 19, 2024
Merged
Add versions to markUsed and markUnused APIs#16141abhishekrb19 merged 17 commits intoapache:masterfrom
markUsed and markUnused APIs#16141abhishekrb19 merged 17 commits intoapache:masterfrom
Conversation
5 tasks
markUsed and markUnused APIs
abhishekrb19
commented
Mar 16, 2024
kfaraz
reviewed
Mar 17, 2024
Contributor
kfaraz
left a comment
There was a problem hiding this comment.
Thanks for the improvement, @abhishekrb19 ! I have left some minor comments.
…esource.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
zachjsh
reviewed
Mar 18, 2024
zachjsh
reviewed
Mar 18, 2024
Contributor
Author
kfaraz
reviewed
Mar 20, 2024
Contributor
There was a problem hiding this comment.
@abhishekrb19 , thanks for merging the PR. The implementation made sense to me. I just have a concern with the treatment of null and empty list of versions. Please refer to the comment for the details.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #15994, this patch adds support for versions to the
markUsedandmarkUnusedAPIs.Segments can now be marked as used or unused within the specified interval using an optional list of versions, i.e.,
(interval, [versions]). Whenversionsis unspecified, all versions of segments in the interval are marked as used or unused, preserving the old behavior before this patch.Release note
Segments can now be marked as used or unused within the specified interval using an optional list of versions, i.e.,
(interval, [versions]). Whenversionsis unspecified, all versions of segments in the interval are marked as used or unused, preserving the old behavior.Sample
markUsedAPI with versions:Sample
markUnusedAPI with versions:Key changed/added classes in this PR
SegmentsMetadataManager.javaSqlSegmentsMetadataManager.javaSqlSegmentsMetadataQuery.javaDatasourcesResource.javaThis PR has: