Skip to content

Web console: fix Azure icon not rendering #16173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogievetsky merged 3 commits into from
Mar 20, 2024
Merged

Web console: fix Azure icon not rendering #16173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35a2616
do not lowercase the icon name
vogievetsky Mar 19, 2024
336753b
missing icon
vogievetsky Mar 19, 2024
00b82db
update test
vogievetsky Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export function getIngestionTitle(ingestionType: IngestionComboTypeWithExtra): s

export function getIngestionImage(ingestionType: IngestionComboTypeWithExtra): string {
const parts = ingestionType.split(':');
if (parts.length === 2) return parts[1].toLowerCase();
if (parts.length === 2) return parts[1];
return ingestionType;
}

Expand Down Expand Up @@ -2071,6 +2071,7 @@ const TUNING_FORM_FIELDS: Field<IngestionSpec>[] = [
{
name: 'spec.tuningConfig.maxPendingPersists',
type: 'number',
defaultValue: 0,
hideInMore: true,
info: (
<>
Expand Down
1 change: 1 addition & 0 deletions web-console/src/utils/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ export function dataTypeToIcon(dataType: string): IconName {
return IconNames.SNOWFLAKE;

case 'COMPLEX<QUANTILESDOUBLESSKETCH>':
case 'COMPLEX<APPROXIMATEHISTOGRAM>':
return IconNames.HORIZONTAL_DISTRIBUTION;

case 'COMPLEX<VARIANCE>':
Expand Down
2 changes: 1 addition & 1 deletion web-console/src/views/load-data-view/__snapshots__/load-data-view.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ exports[`LoadDataView matches snapshot batch 1`] = `
>
<img
alt="Ingestion tile for index_parallel:azureStorage"
src="/some/base_url/assets/azurestorage.png"
src="/some/base_url/assets/azureStorage.png"
/>
<p>
Azure Data Lake
Expand Down