Add errorCode to failure type InternalServerError#16186
Merged
kfaraz merged 1 commit intoapache:masterfrom Mar 23, 2024
Merged
Conversation
LakshSingla
approved these changes
Mar 22, 2024
Contributor
Author
|
Thanks for the review, @LakshSingla ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at other failure types such as
InvalidInput,InvalidSqlInput, etc. it makes sense to have the error code be fixed for a certain of failure.The only two usages of the method
InternalServerError.exception()were actually passing a whole long message in the error code. This would result in theerrorCodefield being populated with the error message and theerrorMsgfield itself taking the value of the first message argument.Changes
internalServerErrorfor failures of this typeInternalServerError.exception()methods thus fixing the above mentioned bug in the callers.