Skip to content

Refactor: Simplify creation of input row filter in various batch tasks#16196

Merged
kfaraz merged 1 commit intoapache:masterfrom
kfaraz:row_filer
Mar 25, 2024
Merged

Refactor: Simplify creation of input row filter in various batch tasks#16196
kfaraz merged 1 commit intoapache:masterfrom
kfaraz:row_filer

Conversation

@kfaraz
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz commented Mar 25, 2024

Changes:

  • Simplify method AbstractBatchIndexTask.defaultRowFilter() and rename
  • Add method allowNonNullWithinInputIntervalsOf()
  • Add javadocs

Copy link
Copy Markdown
Contributor

@abhishekrb19 abhishekrb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kfaraz kfaraz merged commit e7dc00b into apache:master Mar 25, 2024
@kfaraz kfaraz deleted the row_filer branch March 25, 2024 23:24
@kfaraz
Copy link
Copy Markdown
Contributor Author

kfaraz commented Mar 25, 2024

Thanks for the prompt review, @abhishekrb19 !

@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants