Visibility into LagBased AutoScaler desired task count#16199
Merged
georgew5656 merged 6 commits intoapache:masterfrom Mar 27, 2024
Merged
Conversation
Contributor
abhishekrb19
left a comment
abhishekrb19
left a comment
There was a problem hiding this comment.
Looks good overall. I left a few naming suggestions and test verification for the new metrics. Thanks, @adithyachakilam!
Contributor
Author
|
@abhishekrb19 Thanks for the review, addressed the comments! |
kfaraz
reviewed
Mar 26, 2024
ac9817
changed the title
kfaraz
reviewed
Mar 27, 2024
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
Left some final comments.
added 2 commits
March 27, 2024 08:54
georgew5656
approved these changes
Mar 27, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| EasyMock.expect(spec.getSupervisorStateManagerConfig()).andReturn(supervisorConfig).anyTimes(); | ||
|
|
||
| EasyMock.expect(spec.getDataSchema()).andReturn(getDataSchema()).anyTimes(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| { | ||
| EasyMock.expect(spec.getSupervisorStateManagerConfig()).andReturn(supervisorConfig).anyTimes(); | ||
|
|
||
| EasyMock.expect(spec.getDataSchema()).andReturn(getDataSchema()).anyTimes(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Contributor
|
merging as this looks good to me and all the comments have been addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides visibility into the actions taken by
LagBasedAutoScalerand shows us the behaviour of auto scaler. This introduced metric provides insight into what actually is desired task count, how many times did we skip such actions etc. Info obtained from this metric could later be used to tweak the auto scaler config.Release note
ingest/autoScaler/lagBased/requiredTasksandtask/running/countto know the exact gap between current and desired task counts.minTriggerScaleActionFrequencyMillis.Key changed/added classes in this PR
DynamicAllocationTasksNoticeLagBasedAutoScalerThis PR has: