Skip to content

Use created time from metadata store to list multiple active tasks#16228

Merged
AmatyaAvadhanula merged 1 commit intoapache:masterfrom
AmatyaAvadhanula:fix_time_list_active_tasks
Apr 3, 2024
Merged

Use created time from metadata store to list multiple active tasks#16228
AmatyaAvadhanula merged 1 commit intoapache:masterfrom
AmatyaAvadhanula:fix_time_list_active_tasks

Conversation

@AmatyaAvadhanula
Copy link
Copy Markdown
Contributor

Description

The web-console of getTasks API can return incorrect created times and durations afte the Overlord restarts. This is because we populate the field with the time at which the task was added to the TaskRunner for active tasks.

Fix

The method now uses the created_date field from the metadata store as should have been the case for all tasks. No additional calls have been added.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@AmatyaAvadhanula AmatyaAvadhanula changed the title Use created time from metadata store in the method to list multiple active tasks Use created time from metadata store to list multiple active tasks Apr 2, 2024
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@AmatyaAvadhanula AmatyaAvadhanula merged commit 218513a into apache:master Apr 3, 2024
@AmatyaAvadhanula
Copy link
Copy Markdown
Contributor Author

Thank you for the review @kfaraz!
Merged as the failing checks were unrelated.

@kfaraz kfaraz deleted the fix_time_list_active_tasks branch April 30, 2024 09:13
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants