Allow typedIn to run in replace-with-default mode.#16233
Merged
clintropolis merged 2 commits intoapache:masterfrom Apr 4, 2024
Merged
Allow typedIn to run in replace-with-default mode.#16233clintropolis merged 2 commits intoapache:masterfrom
clintropolis merged 2 commits intoapache:masterfrom
Conversation
Useful when data servers, like Historicals, are running in replace-with-default mode and the Broker is running in SQL-compatible mode, which can happen during a rolling update that is applying a mode change.
Contributor
Author
|
I tested this locally by running a Broker in SQL-compatible mode and a Historical in replace-with-default mode. In this case, the Broker generates |
abhishekagarwal87
approved these changes
Apr 3, 2024
Contributor
|
CI is failing due to low branch coverage. |
Contributor
Author
|
I think we should ignore the branch coverage check here, because the relevant branch is There were some legit test failures in the non-SQL-compat |
Contributor
Author
|
The legit failure is fixed; all that's left is the branch coverage failures, which I suggest we ignore. |
clintropolis
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful when data servers, like Historicals, are running in replace-with-default mode and the Broker is running in SQL-compatible mode, which can happen during a rolling update that is applying a mode change.