Skip to content

Web console: don't send lookups to sampler#16234

Merged
vogievetsky merged 1 commit intomasterfrom
dont-send-lookups-to-sampler
Apr 5, 2024
Merged

Web console: don't send lookups to sampler#16234
vogievetsky merged 1 commit intomasterfrom
dont-send-lookups-to-sampler

Conversation

@vogievetsky
Copy link
Copy Markdown
Contributor

@vogievetsky vogievetsky commented Apr 3, 2024

Instead of sending transform expressions containing lookups to the sampler, which is guaranteed to give an error of lookup not found due to lookups not being loaded on the overlord, change the transform to a placeholder so it does not block the flow:

image

image

image

@vogievetsky vogievetsky merged commit 3ba878f into master Apr 5, 2024
@vogievetsky vogievetsky deleted the dont-send-lookups-to-sampler branch April 5, 2024 04:17
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
@maytasm
Copy link
Copy Markdown
Contributor

maytasm commented Apr 24, 2026

@vogievetsky @abhishekrb19

Out of curiosity, why don’t we apply this logic (changeLookupInExpressionsSampling) in the Sampler API backend (SamplerResource) instead of in the frontend?

If the Sampler API is guaranteed to return an error whenever there’s a lookup in the spec, then applying the placeholder on the backend would help in all cases where the Sampler API is called, not just from the Druid Console UI. I also can't see any scenario where getting a 400 Bad Request error with confusing error message ("{"error":"Failed to sample data: Could not transform value for xxx reason: yyy encountered unknown exception."}") would be preferred to the placeholder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants