Web console: don't send lookups to sampler#16234
Merged
vogievetsky merged 1 commit intomasterfrom Apr 5, 2024
Merged
Conversation
abhishekrb19
approved these changes
Apr 5, 2024
Contributor
|
Out of curiosity, why don’t we apply this logic ( If the Sampler API is guaranteed to return an error whenever there’s a lookup in the spec, then applying the placeholder on the backend would help in all cases where the Sampler API is called, not just from the Druid Console UI. I also can't see any scenario where getting a 400 Bad Request error with confusing error message ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of sending transform expressions containing lookups to the sampler, which is guaranteed to give an error of lookup not found due to lookups not being loaded on the overlord, change the transform to a placeholder so it does not block the flow: