Skip to content

Moving bitwise_xor to use native calcite operator#16237

Merged
soumyava merged 2 commits intoapache:masterfrom
somu-imply:bit_xor
Apr 4, 2024
Merged

Moving bitwise_xor to use native calcite operator#16237
soumyava merged 2 commits intoapache:masterfrom
somu-imply:bit_xor

Conversation

@somu-imply
Copy link
Copy Markdown
Contributor

@somu-imply somu-imply commented Apr 4, 2024

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@somu-imply somu-imply marked this pull request as ready for review April 4, 2024 04:56
@somu-imply somu-imply changed the title Moving bitwise_or to use native calcite operator Moving bitwise_xor to use native calcite operator Apr 4, 2024
@soumyava soumyava merged commit 7759f25 into apache:master Apr 4, 2024
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
@adarshsanjeev adarshsanjeev mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clintropolis clintropolis clintropolis approved these changes

Assignees

No one assigned

Labels

Area - Querying

Projects

None yet

Milestone

30.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@somu-imply @clintropolis @adarshsanjeev @soumyava