Adding jvmVersion dimension in JVM Monitor#16262
Merged
soumyava merged 1 commit intoapache:masterfrom Apr 11, 2024
Merged
Conversation
gianm
reviewed
Apr 11, 2024
| private final Map<String, String[]> dimensions; | ||
|
|
||
| private static final String JVM_VERSION = "jvmVersion"; | ||
| private static final String JAVA_VERSION = System.getProperty("java.version"); |
Contributor
There was a problem hiding this comment.
What do these strings typically look like? Just wanting to make sure the thing we are emitting is useful.
Contributor
Author
There was a problem hiding this comment.
here's the typical output of System.getProperty("java.version") for each major Java version:
Java 1.0 - 1.1: These versions didn't have a specific format for java.version. They often returned something like "1.0" or "1.1".
Java 1.2 - 1.4: These versions commonly returned versions like "1.2.2", "1.3.1", or "1.4.2".
Java 5 (1.5): Typically, you'd see versions like "1.5.0_22".
Java 6 (1.6): Commonly returned something like "1.6.0_45".
Java 7 (1.7): Versions often looked like "1.7.0_80".
Java 8 (1.8): Frequently returned versions such as "1.8.0_291".
Java 9 (9): Introduced the new versioning scheme, so you'd see something like "9.0.4".
Java 10: Versions would be like "10.0.1".
Java 11: You'd typically see versions like "11.0.11".
Java 12: Versions could look like "12.0.2".
Java 13: Versions might be something like "13.0.2".
Java 14: Versions could look like "14.0.1".
Java 15: Versions might be like "15.0.1".
Java 16: Versions could look like "16.0.1".
Java 17: Versions might be like "17".
Java 18: Versions might be like "18".
Contributor
Author
There was a problem hiding this comment.
minor versions are postfix with _number
gianm
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has: