Allow Double & null values in sql type array through dynamic params#16274
Merged
kgyrtkirk merged 2 commits intoapache:masterfrom Apr 15, 2024
Merged
Allow Double & null values in sql type array through dynamic params#16274kgyrtkirk merged 2 commits intoapache:masterfrom
kgyrtkirk merged 2 commits intoapache:masterfrom
Conversation
kgyrtkirk
reviewed
Apr 12, 2024
kgyrtkirk
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to take in null & double values while passed through dynamic parameters inside sql type ARRAY
Though we currently will not be able to see the option in UI, this can be achieved through API request.
sample request body's parameters would look like
"parameters":[{"type":"ARRAY","value":[d1, d2, null]}]Release note
Double & Null values can be passed in Array through dynamic parameter
Key changed/added classes in this PR
SqlParameterizerShuttle.javaCalciteArraysQueryTest.javaThis PR has: