Skip to content

Specify node type so that the log filename can get resolved#16282

Merged
FrankChen021 merged 2 commits intoapache:masterfrom
fectrain:specify-nodeType
May 6, 2024
Merged

Specify node type so that the log filename can get resolved#16282
FrankChen021 merged 2 commits intoapache:masterfrom
fectrain:specify-nodeType

Conversation

@fectrain
Copy link
Copy Markdown
Contributor

@fectrain fectrain commented Apr 15, 2024

Fixes #15967

Description

Specify node type in druid.sh so that the log filename(defined in log4j2.xml) can get resolved

image

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@asdf2014 asdf2014 added the Docker https://hub.docker.com/r/apache/druid label Apr 15, 2024
Comment thread distribution/docker/druid.sh Outdated
Co-authored-by: Benedict Jin <asdf2014@apache.org>
@cryptoe
Copy link
Copy Markdown
Contributor

cryptoe commented Apr 15, 2024

@fectrain Could you share a screen shot of the state before this patch as well ?

@fectrain
Copy link
Copy Markdown
Contributor Author

fectrain commented Apr 15, 2024

@fectrain Could you share a screen shot of the state before this patch as well ?

Hi, can refer #15967 , which is just look likes ${sys:druid.node.type}.log

@asdf2014 asdf2014 requested a review from cryptoe May 2, 2024 09:42
@FrankChen021 FrankChen021 merged commit ac42737 into apache:master May 6, 2024
@Subhashini2610
Copy link
Copy Markdown

@fectrain @asdf2014 Thanks for this fix!!! Please let me know in which Druid release would this be present? I somehow do not see it in 30.0.0

@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docker https://hub.docker.com/r/apache/druid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log files are stored as ${sys:druid.node.type}.log

6 participants