Skip to content

Improve logging for lookups#16287

Merged
kfaraz merged 2 commits intoapache:masterfrom
aho135:improve-lookup-logging
Apr 17, 2024
Merged

Improve logging for lookups#16287
kfaraz merged 2 commits intoapache:masterfrom
aho135:improve-lookup-logging

Conversation

@aho135
Copy link
Copy Markdown
Contributor

@aho135 aho135 commented Apr 15, 2024

Description

"Coordinator is unavailable" overstates the problem here. This gets logged even when the coordinator is available but no lookups have been configured.

Changed log message from "Coordinator is unavailable" to "Could not fetch lookups from the coordinator"

Release note

Improved logging when ingestion tasks try to get lookups from the coordinator at startup

If your change doesn't have end user impact, you can skip this section.

For tips about how to write a good release note, see Release notes.

-->


Key changed/added classes in this PR
  • LookupReferencesManager

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

lookupBeanList = getLookupListFromCoordinator(lookupListeningAnnouncerConfig.getLookupTier());
if (lookupBeanList == null) {
LOG.info("Coordinator is unavailable. Loading saved snapshot instead");
LOG.info("No lookup list found from coordinator. Loading saved snapshot instead");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight rephrase:

Suggested change
LOG.info("No lookup list found from coordinator. Loading saved snapshot instead");
LOG.info("Could not fetch lookups from the coordinator. Loading saved snapshot instead.");

@kfaraz
Copy link
Copy Markdown
Contributor

kfaraz commented Apr 17, 2024

Merging as IT failure is unrelated.

@kfaraz kfaraz merged commit 4fa377c into apache:master Apr 17, 2024
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants