Skip to content

Add new metrics for prometheus emitter#16329

Merged
kfaraz merged 1 commit intoapache:masterfrom
ztzxt:add-missing-metrics-prometheus-emitter
Apr 25, 2024
Merged

Add new metrics for prometheus emitter#16329
kfaraz merged 1 commit intoapache:masterfrom
ztzxt:add-missing-metrics-prometheus-emitter

Conversation

@ztzxt
Copy link
Copy Markdown
Contributor

@ztzxt ztzxt commented Apr 24, 2024

Description

I have updated https://github.com/apache/druid/blob/master/extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json and added the query/timeout/count, mergeBuffer/pendingRequests, ingest/events/processedWithError, ingest/notices/queueSize and segment/count metrics.

I also changed the description for query/interrupted/count according to https://druid.apache.org/docs/latest/operations/metrics/

Release note

Improved: Add some missing metrics to the default prometheus-emitter mapping


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@ztzxt ztzxt force-pushed the add-missing-metrics-prometheus-emitter branch from 6bc4924 to 92c0a97 Compare April 24, 2024 12:32
@kfaraz kfaraz merged commit e74da6a into apache:master Apr 25, 2024
@ztzxt ztzxt deleted the add-missing-metrics-prometheus-emitter branch April 29, 2024 17:04
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants