Expend coverage for default mapping for prometheus emitter#16340
Merged
cryptoe merged 1 commit intoapache:masterfrom Apr 27, 2024
Merged
Expend coverage for default mapping for prometheus emitter#16340cryptoe merged 1 commit intoapache:masterfrom
cryptoe merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
We ended up expanding the current default mapping for prometheus-emitter. Therefore decided to share it with the upstream. When deciding between gauge/count types, I used similar (and already existing) metrics as an example. I didn't add the metric if it required some module unless the Prometheus metric was already generated with the default configuration. I re-ordered the existing metrics so they'd reflect the order in the document. I also removed the non-existent metrics such as diff for added/removed metric names: |
3d91203 to
2d27f9c
Compare
Contributor
|
All druid metrics are present here : https://github.com/apache/druid/commits/master/docs/operations/metrics.md |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Went over https://druid.apache.org/docs/latest/operations/metrics/ and added most of missing metrics to prometheus emitter default mapping.
This PR has: