Add new index on datasource and task_allocator_id for pending segments#16355
Merged
AmatyaAvadhanula merged 3 commits intoapache:masterfrom Apr 30, 2024
Merged
Conversation
kfaraz
reviewed
Apr 30, 2024
Contributor
kfaraz
left a comment
There was a problem hiding this comment.
Thanks for the changes, @AmatyaAvadhanula !
Since the index is on datasource + taskAllocatorId, the method IndexerMetadataStorageCoordinator.deletePendingSegmentsForTaskAllocatorId() should accept datasource as an argument too.
kfaraz
approved these changes
Apr 30, 2024
Contributor
Author
|
Thanks for the review, @kfaraz |
AmatyaAvadhanula
added a commit
to AmatyaAvadhanula/druid
that referenced
this pull request
Apr 30, 2024
apache#16355) * Add pending segments index on datasource and task_allocator_id * Use both datasource and task_allocator_id in queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new index on (datasource, task_allocator_id) for the druid_pendingSegments table to optimize fetching of pending segments by task_allocator_id for cleanup and transaction append / replace actions.
The index is added on columns that are (mostly) null, and is not expected to hinder the startup of the Overlord.
I have locally tested this out on a pending segments table with > 2M rows and this operation took 2.14s.
This PR has: