[Web Console] Datasource page support search datasource by keyword#16371
Merged
vogievetsky merged 14 commits intoapache:masterfrom May 24, 2024
Merged
Conversation
fectrain
changed the title
vogievetsky
requested changes
May 16, 2024
Contributor
vogievetsky
left a comment
vogievetsky
left a comment
There was a problem hiding this comment.
This looks really cool, thank you for the change. Added some style comments, also you should run script/licenses (from the web-console directory) to update the license list since you added a package. Do these changes + resolve conflicts and it is good to go IMO
Contributor
Author
|
@vogievetsky Thank you so much for helping on this, I have updated the code as recommended. |
…:fectrain/druid into router_page_support_search_by_datasource
Contributor
Author
|
Hi, @vogievetsky I just merged the latest master branch and now all CI checks has passed, hope it is ready for merging, thank you. |
vogievetsky
approved these changes
May 24, 2024
Contributor
vogievetsky
left a comment
vogievetsky
left a comment
There was a problem hiding this comment.
This is awesome, thank you for addressing the feedback!
ektravel
pushed a commit
to ektravel/druid
that referenced
this pull request
May 29, 2024
…pache#16371) * Frontend segment_timeline support filter by datasource * add dependency * fix eslint issues * resolve code style issue, update snapshot * fix comment * update licence * update package-lock.json * update snapshot * Update segment-timeline.tsx * Update segment-timeline.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16370 .
Description
This PR has: