Remove stale references to killAllDataSources#16387
Merged
kfaraz merged 1 commit intoapache:masterfrom May 5, 2024
Merged
Conversation
This parameter has been removed for awhile now as of Druid 0.23.0 apache#12187. The code was only used in tests to verify that serialization works. Now remove all references to avoid any confusion.
kfaraz
approved these changes
May 5, 2024
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
Thanks for the cleanup, @abhishekrb19 !
IgorBerman
pushed a commit
to IgorBerman/druid
that referenced
this pull request
May 5, 2024
…ces. (apache#16387) This parameter has been removed for awhile now as of Druid 0.23.0 apache#12187. The code was only used in tests to verify that serialization works. Now remove all references to avoid any confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coordinator dynamic config
killAllDataSourceshas been removed since Druid 0.23.0: #12187.As we can see in this patch, the configuration was used only in tests, with no real usage. But since it has been many releases, this patch removes all stale references to it to avoid any confusion.
This PR has: