Cleanup logic from handoff API#16457
Conversation
kfaraz
left a comment
There was a problem hiding this comment.
Thanks for the changes, @georgew5656 .
|
the cds-task-schema-publish-disabled test appears to be hanging and is not cancelling for some reason. i'm pretty sure this is unrelated so i'm going to merge |
I've seen this happen on various PRs after master has been merged into the PR branches. It didn't happen on #16250, the PR that was merged to master immediately before this one. That suggests that possibly this patch did something to make the |
|
Looking through the patch, though, I don't see anything that seems like it would have that effect… |
|
Nevermind, #16250 didn't run the ITs since it was a console only change. I don't think this patch is the one that did it. |
Some followup fixes from: #16310 (review)
Description
Making a few nit fixes from the PR in #16310 (review) for the handoff API
Key changed/added classes in this PR
SupervisorSeekableStreamSupervisorThis PR has: