You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a race condition in CuratorDruidLeaderSelector which may occur as follows:
Current node is elected as leader
LeaderLatchListener.isLeader() is called which calls DruidLeaderSelector.Listener.becomeLeader()
listener.becomeLeader() fails
CuratorDruidLeaderSelector.isLeader() is called and returns false but CuratorDruidLeaderSelector.getCurrentLeader() returns self, because the leader latch has not been updated yet
LeaderLatch is recreated and updated atomically
Subsequent calls to getCurrentLeader() return null until some other node is elected leader
Fix
Update leader = true only after listener.becomeLeader() has succeeded
Return null in getCurrentLeader() if leader = false and LeaderLatch.getLeader() returns self
Other changes
Add some unit tests to CuratorDruidLeaderSelector
Remove unused parameter from K8sDruidLeaderSelector
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.
This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kfaraz
changed the title
Description
There is a race condition in
CuratorDruidLeaderSelectorwhich may occur as follows:LeaderLatchListener.isLeader()is called which callsDruidLeaderSelector.Listener.becomeLeader()listener.becomeLeader()failsCuratorDruidLeaderSelector.isLeader()is called and returnsfalsebutCuratorDruidLeaderSelector.getCurrentLeader()returns self, because the leader latch has not been updated yetLeaderLatchis recreated and updated atomicallygetCurrentLeader()returnnulluntil some other node is elected leaderFix
leader = trueonly afterlistener.becomeLeader()has succeedednullingetCurrentLeader()ifleader = falseandLeaderLatch.getLeader()returns selfOther changes
CuratorDruidLeaderSelectorK8sDruidLeaderSelector