Skip to content

Add IncrementalIndex test#16562

Closed
bsyk wants to merge 1 commit intoapache:masterfrom
bsyk:objectselector-incrementalindex
Closed

Add IncrementalIndex test#16562
bsyk wants to merge 1 commit intoapache:masterfrom
bsyk:objectselector-incrementalindex

Conversation

@bsyk
Copy link
Copy Markdown
Contributor

@bsyk bsyk commented Jun 5, 2024

Test that should repro the IncrementalIndex + ComplexColumn + longSum aggregator issue

.setGranularity(Granularities.HOUR)
.setInterval("1970/2050")
.setAggregatorSpecs(
new DoubleSumAggregatorFactory("doubleSum", "histogram")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see why this is beneficial at all - why can't the user invoke a method which will translate the histogram to a literal and the aggregate those values with sum?

I think an aggregate which is repesented by a sketch or something could normally not be represented by a single literal number; if we want to introduce something which translates the sketch to some other type automatically - I think that should be registered properly and not hidden in the aggregator as some bonus functionality.

am I alone with this mindset?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 6, 2024

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Aug 6, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 3, 2024

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants