Skip to content

Web console: fix pagination and filtering regression in supervisor view#16571

Merged
cryptoe merged 2 commits intoapache:masterfrom
vogievetsky:fix_pagination_and_filtering_in_supervisor_view
Jun 7, 2024
Merged

Web console: fix pagination and filtering regression in supervisor view#16571
cryptoe merged 2 commits intoapache:masterfrom
vogievetsky:fix_pagination_and_filtering_in_supervisor_view

Conversation

@vogievetsky
Copy link
Copy Markdown
Contributor

@vogievetsky vogievetsky commented Jun 7, 2024

This PR fixes 3 bugs in the supervisor view introduced as part of #16318:

  • Pagination will never show up because dynamically queried supervisors will never satisfy the supervisors.length > SMALL_TABLE_PAGE_SIZE condition
  • Filtering on the Status column fails. This is due to a typo (internally the column is actually called detailed_state)
  • Typing something into the filter then deleting it produces an invalid query with an empty WHERE

@vogievetsky vogievetsky added this to the 30.0.0 milestone Jun 7, 2024
@adarshsanjeev adarshsanjeev mentioned this pull request Jun 7, 2024
Closed
cryptoe
cryptoe reviewed Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@cryptoe cryptoe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vogievetsky The UT failure looks legit.

@cryptoe cryptoe merged commit efe9079 into apache:master Jun 7, 2024
@vogievetsky vogievetsky deleted the fix_pagination_and_filtering_in_supervisor_view branch June 7, 2024 15:40
cryptoe pushed a commit to cryptoe/druid that referenced this pull request Jun 7, 2024
@vogievetsky @cryptoe
Web console: fix pagination and filtering regression in supervisor vi…
abba3f0 
…ew (apache#16571)

* fix pagination and filtering in supervisor view

* update snapshot

(cherry picked from commit efe9079)
@cryptoe cryptoe mentioned this pull request Jun 7, 2024
Merged
vogievetsky added a commit that referenced this pull request Jun 7, 2024
@cryptoe @vogievetsky
Web console: fix pagination and filtering regression in supervisor vi…
925bbc2 
…ew (#16571) (#16575)

* fix pagination and filtering in supervisor view

* update snapshot

(cherry picked from commit efe9079)

Co-authored-by: Vadim Ogievetsky <vadim@ogievetsky.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryptoe cryptoe cryptoe approved these changes

Assignees

No one assigned

Labels

Area - Web Console Bug

Projects

None yet

Milestone

30.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@vogievetsky @cryptoe