Skip to content

Web console: expose handoff API#16586

Merged
vogievetsky merged 8 commits intoapache:masterfrom
vogievetsky:catch-up-to-api
Aug 16, 2024
Merged

Web console: expose handoff API#16586
vogievetsky merged 8 commits intoapache:masterfrom
vogievetsky:catch-up-to-api

Conversation

@vogievetsky
Copy link
Copy Markdown
Contributor

Expose handoff API added in #16310

image image

@johnImply
Copy link
Copy Markdown
Contributor

Where on the UI are the Task Group IDs found?

If this is the "Group ID" value from the Tasks tab, then would it make more sense to implement the "Early Handoff" option on the Tasks tab instead of the Supervisor tab?

I understand it is the Supervisor that needs the direct instruction and not the Task ... but from a user perspective it is the task that I am cycling, not the Supervisor.

Thanks. John

@georgew5656
Copy link
Copy Markdown
Contributor

Where on the UI are the Task Group IDs found?

If this is the "Group ID" value from the Tasks tab, then would it make more sense to implement the "Early Handoff" option on the Tasks tab instead of the Supervisor tab?

I understand it is the Supervisor that needs the direct instruction and not the Task ... but from a user perspective it is the task that I am cycling, not the Supervisor.

Thanks. John

the task's taskGroupId is under the streaming task -> ioConfig -> taskGroupId. i think it still makes sense to have it on the supervisor (since you can specify multiple tasks to handoff, and like you said the api is operating on the supervisor). it would be nice to have a more explicit group -> task_id mapping available somewhere in the superivsor though.

i have observed that the Statistics tab for the supervisor already shows tasks by ascending group id (1,2,3,4,5, etc) so maybe it could be there, or alternatively just in the status page

Comment thread web-console/src/dialogs/supervisor-handoff-dialog/supervisor-handoff-dialog.tsx Outdated
Comment thread web-console/src/dialogs/supervisor-handoff-dialog/supervisor-handoff-dialog.tsx Outdated
Comment thread web-console/src/dialogs/supervisor-handoff-dialog/supervisor-handoff-dialog.tsx Outdated
Copy link
Copy Markdown
Contributor

@ektravel ektravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions.

@johnImply
Copy link
Copy Markdown
Contributor

Verbiage ... do we need to make a distinction between "supervisor handoff" and "task group handoff"?

I thought a "supervisor handoff" involved cycling all tasks for the supervisor ... this is what we can do by "Open in Data Loader" and then Submit without making any changes to the supervisor spec.

If there is any ambiguity here it might be safer to always reference "task group(s)" as the thing being handed off. My understanding is that Supervisor is merely the orchestrator here.

vogievetsky and others added 3 commits June 12, 2024 13:54
…andoff-dialog.tsx

Co-authored-by: Katya Macedo  <38017980+ektravel@users.noreply.github.com>
…andoff-dialog.tsx

Co-authored-by: Katya Macedo  <38017980+ektravel@users.noreply.github.com>
…andoff-dialog.tsx

Co-authored-by: Katya Macedo  <38017980+ektravel@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@ektravel ektravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Aug 12, 2024
@vogievetsky vogievetsky merged commit 422183e into apache:master Aug 16, 2024
@vogievetsky vogievetsky deleted the catch-up-to-api branch August 16, 2024 21:39
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants