Skip to content

CgroupCpuSetMonitor: Initialize the cgroup discoverer#16621

Merged
suneet-s merged 1 commit intoapache:masterfrom
ac9817:adithyac/cpuset-monitor
Jun 20, 2024
Merged

CgroupCpuSetMonitor: Initialize the cgroup discoverer#16621
suneet-s merged 1 commit intoapache:masterfrom
ac9817:adithyac/cpuset-monitor

Conversation

@ac9817
Copy link
Copy Markdown
Contributor

@ac9817 ac9817 commented Jun 17, 2024

Description

Fixes the null pointer exceptions when the monitor is enabled.


Key changed/added classes in this PR
  • CgroupCpuSetMonitor

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@suneet-s
Copy link
Copy Markdown
Contributor

Overruling CI because it's failing on coverage

@suneet-s suneet-s merged commit 35709de into apache:master Jun 20, 2024
@kgyrtkirk
Copy link
Copy Markdown
Member

fyi: there were 6 failing jobs ; one of them failed with injector issues:
https://github.com/apache/druid/actions/runs/9555883049/job/26342057882

the issue is rather strange - and it doesn't seem related at all to this PR; it could be some flaky issue?

I think it would be great to have a sacred way of disabling the coverage check for a PR - as it may hide legitim issues by creating noise

@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants