remove native scan query legacy mode#16659
Conversation
ea3a7cf to
670bc02
Compare
|
CI failures are related to coverage, which I guess means this stuff wasn't well covered in the first place since I am only removing stuff in this PR. Can look into maybe adding some more tests to get it happy, but also doesn't really feel like a blocker |
| } | ||
|
|
||
| @Nullable | ||
| public RowSignature getRowSignature(boolean defaultIsLegacy) |
|
oh...covereage change issues have prevented further tests from being run... In this case I think that doesn't really apply as these jobs were running with |
|
|
||
| ## Legacy mode | ||
|
|
||
| In older versions of Druid, the scan query supported a legacy mode designed for protocol compatibility with the former scan-query contrib extension from versions of Druid older than 0.11. This mode has been removed. |
There was a problem hiding this comment.
Nit: Should we also add that this mode is removed from druid 31.
There was a problem hiding this comment.
i considered this, but then also thought it was kind of embarrassing that it took so long to remove it, so not really sure we needed to highlight that. Also I can't imagine that many people are using it, i think the only reason to do it is if you were originally using the contrib extension. The only reason I didn't remove it entirely from the docs was just in case people are searching for what it means in native query json stuff have something to reference.
If you think there is some actionable purpose to specify which version it was removed in i can add it, but it doesn't seem too important to me.
apache#16793) Fixes rolling downgrades/upgrades after apache#16659 by hard coding scan query "legacy":false since it is a required property during deserialization.
Description
The native scan query was moved from a contrib extension into core in Druid 0.11 in #4751, which introduced a 'legacy' option to maintain backwards compatibility with the extension, which used a non-standard time column name and always included this timestamp in the results.
I think sufficient time has passed to allow us to remove this parameter to help simplify code a bit.
Release note
The native scan query 'legacy' mode has been removed, which was introduced in Druid 0.11 to maintain compatibility during an upgrade from older versions of Druid where the scan query was part of a 'contrib' extension.
This PR has: