Better error handling when retrieving Avro schemas from registry#16684
Merged
abhishekrb19 merged 3 commits intoapache:masterfrom Jul 2, 2024
Merged
Conversation
… error. - Add tests - Clean up the tests; remove the legacy expected exception pattern - Better test assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when retrieving an Avro schema from the registry and if the request fails with an
IOExceptionor aRestClientException, we bubble this generic error up to the user:However, this error message is misleading in cases where the server is throwing unauthorized/forbidden error codes via
RestClientException. So now we handleIOExceptionandRestClientExceptionseparately so that we can bubble up more specific errors rather than the common template.Added unit tests for the change and also cleaned up test annotations
@Test(expected = ParseException.class)by adding better tests assertions.This PR has: