Add logging for sketches on workers#16697
Merged
LakshSingla merged 2 commits intoapache:masterfrom Jul 9, 2024
Merged
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
LakshSingla
reviewed
Jul 9, 2024
Contributor
LakshSingla
left a comment
LakshSingla
left a comment
There was a problem hiding this comment.
The controller should also rely on the logSketches() method to explicitly log the sketches. Currently, it's done implicitly in generatePartitionsWithTargetWeight and generatePartitionsWithMaxCount.
LakshSingla
approved these changes
Jul 9, 2024
Contributor
|
Thanks for the patch! |
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
Improve the logging of sketches on workers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to improve the logging of sketches on workers.
This function is already called on the controller to print information regarding the most downsampled sketches. This should give more information on the sketches being downsampled at a worker level.