kubernetes-overlord-extension: Fix tasks not being shutdown#16711
Merged
georgew5656 merged 4 commits intoapache:masterfrom Jul 15, 2024
Merged
kubernetes-overlord-extension: Fix tasks not being shutdown#16711georgew5656 merged 4 commits intoapache:masterfrom
georgew5656 merged 4 commits intoapache:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| maybePod = kubernetesClient.getPeonPod(taskId.getK8sJobName()); | ||
| } | ||
| catch (Exception e) { | ||
| log.makeAlert("Unable to get location for task", e) |
Check warning
Code scanning / CodeQL
Unused format argument
georgew5656
reviewed
Jul 11, 2024
Contributor
georgew5656
left a comment
georgew5656
left a comment
There was a problem hiding this comment.
would it make sense to just put this in KubernetesTaskRunner.getTaskLocation since that's the method that TaskQueue calls? it seems like we really don't want that function specifically to ever throw a exception
added 2 commits
July 15, 2024 11:55
georgew5656
approved these changes
Jul 15, 2024
cryptoe
reviewed
Jul 19, 2024
| } | ||
| } | ||
| catch (Exception e) { | ||
| log.warn("Unable to find location for task [%s]", taskId); |
Contributor
There was a problem hiding this comment.
Is there a reason we are not logging the exception ?
Contributor
There was a problem hiding this comment.
good point, will add it in
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
FrankChen021
pushed a commit
that referenced
this pull request
Feb 3, 2025
GabrielCWT
pushed a commit
to GabrielCWT/druid
that referenced
this pull request
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In rare cases when fabric client is unable to talk to the k8s server, TaskQueue is skipping the complete shutdown logic because of the exception thrown during figuring task location. This PR allows to continue the shutdown logic without populating the location on task status and thus allowing to clean up all the data structures.
Key changed/added classes in this PR
KubernetesPeonLifecycleThis PR has: