Merged
Conversation
AmatyaAvadhanula
approved these changes
Jul 10, 2024
Contributor
AmatyaAvadhanula
left a comment
AmatyaAvadhanula
left a comment
There was a problem hiding this comment.
Thanks for the fix @kfaraz
| @@ -234,12 +234,13 @@ private boolean cancelTaskIfGranularityChanged( | |||
| Granularity configuredSegmentGranularity = dataSourceCompactionConfig.getGranularitySpec() | |||
| .getSegmentGranularity(); | |||
| Granularity taskSegmentGranularity = compactionTaskQuery.getGranularitySpec().getSegmentGranularity(); | |||
Contributor
There was a problem hiding this comment.
The fix makes sense. It seems that the members and getters in UserCompactionTaskGranularityConfig are missing @Nullable annotations. Could we also update those?
Also, for this bug fix, it'll be good to update an existing test in CompactSegmentsTest or another relevant test to pass null values to the compaction task query.
Contributor
Author
There was a problem hiding this comment.
Some of the @Nullable annotations are being added in another PR #16291 , so I skipped them here.
Okay if we add the tests separately? I want to merge this PR and not wait for another CI build.
abhishekrb19
approved these changes
Jul 10, 2024
asdf2014
approved these changes
Jul 10, 2024
Contributor
Author
|
Thanks for the prompts reviews, @AmatyaAvadhanula , @abhishekrb19 , @asdf2014 ! |
10 tasks
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NPE causes
CompactSegmentsduty to fail and thus not submit any compaction tasks.