Skip to content

Window Function offset correction for RAC#16718

Merged
kgyrtkirk merged 7 commits intoapache:masterfrom
sreemanamala:rac-offset
Jul 15, 2024
Merged

Window Function offset correction for RAC#16718
kgyrtkirk merged 7 commits intoapache:masterfrom
sreemanamala:rac-offset

Conversation

@sreemanamala
Copy link
Copy Markdown
Contributor

@sreemanamala sreemanamala commented Jul 10, 2024 •
edited
Loading

Description

Changes in this commit :

  1. When an ArrayList RAC creates a child RAC, the start and end offsets need to have the offset of parent's start offset
  2. Defaults the 2nd window bound to CURRENT ROW when only a single bound is specified
  3. Removes the windowingStrictValidation warning and throws a hard exception when Order By alongside RANGE clause is not provided with UNBOUNDED or CURRENT ROW as both bounds
Key changed/added classes in this PR
  • DruidSqlValidator
  • ArrayListRowsAndColumns

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

kgyrtkirk
kgyrtkirk reviewed Jul 11, 2024
View reviewed changes
Comment thread sql/src/test/resources/calcite/tests/window/range_handling.sqlTest
Comment on lines -13 to -15
'k(1)',
COUNT(1) OVER (ORDER BY FLOOR(m1/3) ROWS BETWEEN 1 PRECEDING AND 1 FOLLOWING),
COUNT(1) OVER (ORDER BY FLOOR(m1/3) RANGE BETWEEN 1 PRECEDING AND 1 FOLLOWING)
Copy link
Copy Markdown
Member

@kgyrtkirk kgyrtkirk Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this test; and not just these?

Copy link
Copy Markdown
Contributor Author

@sreemanamala sreemanamala Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, make sense to just remove these 1 PRECEDING AND 1 FOLLOWING. Later on when we start supporting them, we can modify this test to keep the comparisons between ROWS and RANGE in different scenarios at one place. will update it. Thanks for the review @kgyrtkirk !!

@kgyrtkirk kgyrtkirk merged commit 78a4a09 into apache:master Jul 15, 2024
sreemanamala added a commit to sreemanamala/druid that referenced this pull request Aug 6, 2024
@sreemanamala
Window Function offset correction for RAC (apache#16718)
8028efb 
* When an ArrayList RAC creates a child RAC, the start and end offsets need to have the offset of parent's start offset
* Defaults the 2nd window bound to CURRENT ROW when only a single bound is specified
* Removes the windowingStrictValidation warning and throws a hard exception when Order By alongside RANGE clause is not provided with UNBOUNDED or CURRENT ROW as both bounds
@sreemanamala sreemanamala deleted the rac-offset branch September 18, 2024 11:24
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
@kfaraz kfaraz mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgyrtkirk kgyrtkirk kgyrtkirk approved these changes

Assignees

No one assigned

Labels

Area - Querying

Projects

None yet

Milestone

31.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sreemanamala @kgyrtkirk @kfaraz