#16717 defer provider instantiation in Kubernetes Module#16726
Merged
georgew5656 merged 3 commits intoapache:masterfrom Jul 16, 2024
Merged
#16717 defer provider instantiation in Kubernetes Module#16726georgew5656 merged 3 commits intoapache:masterfrom
georgew5656 merged 3 commits intoapache:masterfrom
Conversation
georgew5656
approved these changes
Jul 12, 2024
Contributor
Author
|
Tests failing:
Let me now if that's ok or how can i test the module provider |
Contributor
Author
|
208.8 Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.apache.druid.extensions.contrib:aliyun-oss-extensions:jar:31.0.0-SNAPSHOT in (https://repo1.maven.org/maven2/) On docker build. Dont know why this failed, but completely unrelated to my changes id say |
Contributor
|
i think the gha runner was probably killed during the build, it succeeded when i retried. thanks for the change. |
edgar2020
pushed a commit
to edgar2020/druid
that referenced
this pull request
Jul 19, 2024
…e#16726) * apache#16717 defer provider instatiation * add license header * fix style, ignore new class in jacoco as it is still initialization code --------- Co-authored-by: Alberto Lago Alvarado <albl@sitecore.net>
edgar2020
pushed a commit
to edgar2020/druid
that referenced
this pull request
Jul 19, 2024
…e#16726) * apache#16717 defer provider instatiation * add license header * fix style, ignore new class in jacoco as it is still initialization code --------- Co-authored-by: Alberto Lago Alvarado <albl@sitecore.net>
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
…e#16726) * apache#16717 defer provider instatiation * add license header * fix style, ignore new class in jacoco as it is still initialization code --------- Co-authored-by: Alberto Lago Alvarado <albl@sitecore.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16717
Description
Hadoop ingestion doesnt have access to K8s config. Provider not being pure lazy was making the HadoopIndexTask fail altho it doesnt really need K8s information on the Hadoop cluster.
This PR refactors the DruidLeaderSelectorProvider class so its creation can be deferred to Module instantiation, thus not happening on HadoopIndexTask
It creates 2 subclasses CoordinatorDruidLeaderSelectorProvider and IndexingServiceDruidLeaderSelectorProvider which can be properly referenced.
Was not sure about either overriding the get method on children or keep the parents, so i decided to take the option with less code changes.
Let me know if the other option id preferred.
Release note
Key changed/added classes in this PR
This PR has: