Process retrieval of parent and child segment ids in batches#16734
Merged
kfaraz merged 1 commit intoapache:masterfrom Jul 15, 2024
Merged
Conversation
kfaraz
approved these changes
Jul 15, 2024
Contributor
|
Thanks for the quick fix, @AmatyaAvadhanula ! |
Contributor
Author
|
Thanks for the review, @kfaraz! |
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16667 introduced two new metadata store queries to fetch parent ids and children ids corresponding to a given set of input segment ids using an IN clause.
This PR modifies these methods to process segmentIds in batches of size at most 100 for better performance and to hold the read transactions for shorter periods of time.
This PR has: