Enable WINDOW_LEAF_OPERATOR for native engine to support queries without group by#16753
Merged
kgyrtkirk merged 2 commits intoapache:masterfrom Jul 22, 2024
Merged
Enable WINDOW_LEAF_OPERATOR for native engine to support queries without group by#16753kgyrtkirk merged 2 commits intoapache:masterfrom
kgyrtkirk merged 2 commits intoapache:masterfrom
Conversation
kgyrtkirk
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit is to temporarily fix the issues with window queries without a group by clause, by setting the leaf operator to empty instead of null so as to stop the planner to rewrite the query assigning a leaf operator.
Once the Wire Transferable interface is fixed, we can disable this.
Key changed/added classes in this PR
NativeSqlEngineThis PR has: