Check for Unsupported Aggregation with Distinct when useApproxCountDistinct is enabled#16770
Merged
asdf2014 merged 9 commits intoapache:masterfrom Jul 24, 2024
Merged
Check for Unsupported Aggregation with Distinct when useApproxCountDistinct is enabled#16770asdf2014 merged 9 commits intoapache:masterfrom
asdf2014 merged 9 commits intoapache:masterfrom
Conversation
kgyrtkirk
reviewed
Jul 22, 2024
asdf2014
reviewed
Jul 23, 2024
kgyrtkirk
approved these changes
Jul 23, 2024
asdf2014
approved these changes
Jul 24, 2024
sreemanamala
added a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
…stinct is enabled (apache#16770) * init * add NativelySupportsDistinct * refactor * javadoc * refactor * fix tests * fix drill tests * comments * Update sql/src/test/java/org/apache/druid/sql/calcite/DrillWindowQueryTest.java --------- Co-authored-by: Benedict Jin <asdf2014@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checks and throws an actionable error in case we encounter any aggregator using distinct which does not support it as mentioned in this issue
Key changed/added classes in this PR
NativelySupportsDistinctDruidSqlValidatorGroupByRulesThis PR has: